Skip to content

docs: add import.meta.dirname/filename to Advocacy Ambassador Program#60598

Open
ghiscoding wants to merge 2 commits into
nodejs:mainfrom
ghiscoding:patch-1
Open

docs: add import.meta.dirname/filename to Advocacy Ambassador Program#60598
ghiscoding wants to merge 2 commits into
nodejs:mainfrom
ghiscoding:patch-1

Conversation

@ghiscoding

Copy link
Copy Markdown

Add new import.meta.dirname and import.meta.filename to Advocacy Ambassador Program

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 6, 2025
@ghiscoding

Copy link
Copy Markdown
Author

@marco-ippolito hi there, I see you were the last person who modified this file (2 months ago). I made my PR a while ago, does this PR make any sense? if not, I'll just close it, since there's probably no reason to keep this open for so long. Cheers

@trivikr

trivikr commented Jul 21, 2026

Copy link
Copy Markdown
Member

@ghiscoding Can you sign the first commit as per instructions for force push with lease?

Your commit must contain the Signed-off-by line with your name and email address as an acknowledgement that you agree to the Developer Certificate of Origin.

@ghiscoding
ghiscoding force-pushed the patch-1 branch 2 times, most recently from 08c2c7c to f2af421 Compare July 22, 2026 04:46
@trivikr

trivikr commented Jul 22, 2026

Copy link
Copy Markdown
Member

During rebase, a commit body was populated, which appears to be an error

docs: add import.meta.dirname/filename to Advocacy Ambassador Program

(cherry picked from commit becaf04)

Signed-off-by: ghiscoding <email>

Can you remove it and force push?

@ghiscoding
ghiscoding force-pushed the patch-1 branch 3 times, most recently from 8b040e7 to 2c57b98 Compare July 22, 2026 04:57
(cherry picked from commit becaf04)
Signed-off-by: Ghislain Beaulac <gbeaulac@gmail.com>
(cherry picked from commit 0cff1c5)
Signed-off-by: Ghislain Beaulac <gbeaulac@gmail.com>
@ghiscoding

ghiscoding commented Jul 22, 2026

Copy link
Copy Markdown
Author

@trivikr I think it's done and this was very painful (using AI), I never want to do this ever again, this will probably be my first and last commit to this repo... other projects are much easier to sign, typically just a checkbox to click or special text to type in (e.g. I pushed code to Microsoft and it was just a checkbox to click)

@avivkeller

avivkeller commented Jul 22, 2026

Copy link
Copy Markdown
Member

I think it's done and this was very painful (using AI), I never want to do this ever again, this will probably be my first and last commit to this repo... other projects are much easier to sign, typically just a checkbox to click or special text to type in (e.g. I pushed code to Microsoft and it was just a checkbox to click)

I'm sorry to hear that. For future reference, git commit --amend -s --no-edit will add the required trailer to the most recent commit.

I'd imagine something like:

git rebase origin/main --exec 'git commit --amend --no-edit -s'

Would work for PRs with multiple commits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants