docs: add import.meta.dirname/filename to Advocacy Ambassador Program#60598
docs: add import.meta.dirname/filename to Advocacy Ambassador Program#60598ghiscoding wants to merge 2 commits into
Conversation
|
Review requested:
|
|
@marco-ippolito hi there, I see you were the last person who modified this file (2 months ago). I made my PR a while ago, does this PR make any sense? if not, I'll just close it, since there's probably no reason to keep this open for so long. Cheers |
|
@ghiscoding Can you sign the first commit as per instructions for force push with lease?
|
08c2c7c to
f2af421
Compare
|
During rebase, a commit body was populated, which appears to be an error docs: add import.meta.dirname/filename to Advocacy Ambassador Program
(cherry picked from commit becaf04)
Signed-off-by: ghiscoding <email>Can you remove it and force push? |
8b040e7 to
2c57b98
Compare
|
@trivikr I think it's done and this was very painful (using AI), I never want to do this ever again, this will probably be my first and last commit to this repo... other projects are much easier to sign, typically just a checkbox to click or special text to type in (e.g. I pushed code to Microsoft and it was just a checkbox to click) |
I'm sorry to hear that. For future reference, I'd imagine something like: git rebase origin/main --exec 'git commit --amend --no-edit -s'Would work for PRs with multiple commits? |
Add new
import.meta.dirnameandimport.meta.filenameto Advocacy Ambassador Program